Ethereal-dev: Re: [ethereal-dev] stupid -Wall patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Tue, 26 Oct 1999 14:49:02 -0700 (PDT)
> maybe my types are different then everyone elses but ntohl() returns
> an unsigned long for me..

"It's a FreeBSD thing" (or maybe a BSD thing in general).

> this fixes the warning.

I checked in a fix for that one on 1999-10-22 (my Ethereal development
at home is done on FreeBSD), although, so that the compiler doesn't
whine on platforms where "ntohl()" returns an "int"-sized data type, I
did

		col_add_fstr(fd, COL_INFO,
			"Type: %s  "
			"Seq: %lu  "
			"Call: %lu  "
			"Source Port: %s  "
			"Destination Port: %s  ",
			val_to_str(rxh->type, rx_types, "%d"),
			(unsigned long)ntohl(rxh->seq),
			(unsigned long)ntohl(rxh->callNumber),
			get_udp_port(pi.srcport),
			get_udp_port(pi.destport)
		);

That was after 0.7.6 went out the door, so 0.7.6 still gets the warning.