> This adds initial dissector support for NTP. Still need to add a
> bitfield for the flags, and possibly further process the floating point
> fields, but this is a start. At the moment, everything is just split
> into bytes.
>
> A patch and two files are attached.
Checked in.
> Index: packet-tcp.c
> ===================================================================
> RCS file: /cvsroot/ethereal/packet-tcp.c,v
> retrieving revision 1.35
> diff -u -r1.35 packet-tcp.c
> --- packet-tcp.c 1999/10/14 01:28:26 1.35
> +++ packet-tcp.c 1999/10/14 04:25:17
> @@ -76,6 +76,7 @@
> #define TCP_PORT_HTTP 80
> #define TCP_PORT_POP 110
> #define TCP_PORT_NNTP 119
> +#define TCP_PORT_NTP 123
> #define TCP_PORT_NBSS 139
> #define TCP_PORT_PRINTER 515
> #define TCP_ALT_PORT_HTTP 8080
> @@ -485,8 +486,10 @@
> pi.match_port = TCP_PORT_POP;
> dissect_pop(pd, offset, fd, tree);
> } else if (PORT_IS(TCP_PORT_NNTP)) {
> - pi.match_port = TCP_PORT_NNTP;
Nope, the NNTP dissector uses that to decide whether something's an NNTP
request or response.
> Index: packet.h
> ===================================================================
> RCS file: /cvsroot/ethereal/packet.h,v
> retrieving revision 1.107
> diff -u -r1.107 packet.h
> --- packet.h 1999/10/14 01:28:28 1.107
> +++ packet.h 1999/10/14 04:25:22
> @@ -270,6 +270,8 @@
> ETT_TELNET,
> ETT_TELNET_SUBOPT,
> ETT_NNTP,
> + ETT_NTP,
> + ETT_NTP_FLAGS,
> ETT_SNMP,
> ETT_NBSS,
> ETT_NBSS_FLAGS,
I also added a declaration of "dissect_ntp()" - the dissector(s)
exported by a "packet-XXX.c" file should be declared in "packet.h".
