Ethereal-dev: Re: [ethereal-dev] cvs commit: ethereal packet-aarp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Wed, 06 Oct 1999 14:03:29 -0500
On Wed, Oct 06, 1999 at 11:23:55AM -0700, Guy Harris wrote:
> Unfortunately, it appears that "dfilter_mknode_ipv4_value()" is being
> called with "cable19" as an argument, not "cable19-003.gte.net"; you
> probably need to make the "looks like a protocol or field name" case
> accept "\-", as RFC 1034 says that host names can include, as characters
> other than the first character, letters, digits, or hyphens.
> 
> This patch appears to fix that problem (and also fixes the comment):

Yup, that seems to fix it, and to my own surprise :-), w/o breaking
hardware addresses using hyphens as separators. (ff-ff-ff-ff-ff-ff)

I'll check it in.

thanks,

--gilbert