Ethereal-dev: Re: [ethereal-dev] Some more patches to ethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Mon, 04 Oct 1999 23:54:02 -0500
On Thu, Sep 30, 1999 at 01:07:55PM +0300, Santeri Paavolainen wrote:
> Here's a small patch which fixes a SEGV dumper, and makes the previous
> color to be the default for the color chooser.

Thanks. I had already applyed the SEGV fix. I have checked in
your default color patch.

> *** ethereal-0.7.5-orig/file.c	Fri Sep 24 17:50:47 1999
> --- ethereal-0.7.5/file.c	Thu Sep 30 10:13:35 1999
> ***************
> *** 1007,1012 ****
> --- 1007,1016 ----
>       if (fd->row == row)
>         break;
>     }
> + 
> +   if (fd == NULL)
> +     return;
> + 
>     cf->fd = fd;

I made this one:
	g_assert(fd != NULL);

since it shouldn't be happening. Has it happened to you?

--gilbert