Ethereal-dev: Re: [ethereal-dev] LLC/xdlc bug

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Sun, 26 Sep 1999 13:01:59 -0700
> Am I reasoning correctly? Can I just change line 298 to add 4 to the
> offset?

Yes, *if* the frame isn't an unnumbered frame.  Perhaps
"dissect_xdlc_control()" needs to return both the control field length
*and* an indication of whether the frame has a payload or not.  (Or,
alternatively, it could return the raw control field, and we could have
macros in "xdlc.h" to determine from a control field whether the frame
has a payload or not and how long the field is.)

> Attached is the gzipped (thanks Ashok!) Sniffer file. Frame 8 shows
> this, although it will call dissect_data() in all copies of ethereal
> except mine (where I have a nascent dissect_sna() ).

I was thinking that, now that we have an SNA capture, *somebody* should
look at that - thanks for keeping me from doing so. :-)