Ethereal-dev: Re: [ethereal-dev] Fun with performance

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Sat, 28 Aug 1999 18:45:10 -0500
On Sat, Aug 28, 1999 at 05:39:43PM -0500, John McDermott wrote:
> 
> 
> I see no reason not to change the order if it improves performance.
> Unless I am reading the code incorrectly, the filter is indeed only
> applied once.  What *is* done for each filter is the comparison with the
> data (this may just be semantics).  I do not see any functional
> difference if you do the change, though.

dfilter_apply() is called for each color filter, on every packet.
That's the comparison of the filter against the data, and what I was
referring to as "applied". 
 
> I just did a quick test and it looks fine.  The messages in colors.c
> need to be changed to reflect the new processing of the list.  I should
> probably get rid of the ifdef debuggery in file.c, as well.  I can take
> care of it Monday, or if you feel inclined, Gilbert, you can do it.
> All  I did to test it was add a break:

I'll have a go at it.

thanks,

--gilbert