Ethereal-dev: Re: [ethereal-dev] Fun with performance

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Sat, 28 Aug 1999 17:19:47 -0500
On Thu, Aug 26, 1999 at 04:19:33PM -0500, Jeff Jahr wrote:
> 
>         On the subject of performance, I believe [1] that the color filter
> code is set up to always try and apply each color filter in the list to
> each packet being decoded.
> 
>         Changing that function to 'the first matching color filter in list
> is the one applied' from 'all matching color filters are applied in order'
> would be good optimization with no loss of functionality...

Yes, that's true. John, would we lose any functionality if we stopped
applying the color display filters when we first find a matching filter?
It would mean that the user would have to sort his color filters in reverse
order to how they are now. That is, any filters matching on a high-level
protocol should come first, and filters matching on the lower layers should
come last:

	FTP = red on white
	TCP = blue on white
	IP = white on read
	TRMAC = white on blue

Would the colorization still provide what it provides now?

--gilbert