Ethereal-dev: Re: [ethereal-dev] Filter Colorization patch(es)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Mon, 23 Aug 1999 14:17:32 -0500
On Mon, Aug 23, 1999 at 11:56:25AM -0500, John McDermott wrote:
> 
> 
> 
> Here is the filter colorization stuff as it stands today.  It allows:
> Loading and saving of filters.
> Arbitrary foreground and background colors for any protocol filter you
>   can write with Gilbert's dfilters.
> (Hopefully) unlimited number of filters.
> Filters are processed in a list from top to bottom so if you have:
> IP on one line then TCP on the next, the TCP one will be used if the
> packet is IP/TCP.

This is really good work. It will make Ethereal much more attractive
to a lot of people.

In colors.c, line 492, the first row of a clist is 0, not 1, so, the line
should be:

         cf.colors->row_selected = 0;

In colors.h, you might want to add:

#ifndef __GTK_H__
#include <gtk/gtk.h>
#endif

to the top, inside the __COLORS_H__ block, and remove that gtk/gtk.h include
from the last line.

--gilbert