Ethereal-dev: Re: [ethereal-dev] -Wall fixes for FreeBSD

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Bill Fumerola <billf@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 3 Aug 1999 08:41:38 -0400 (EDT)
On Mon, 2 Aug 1999, Guy Harris wrote:

> "packet-isakmp.c", in the CVS tree, is already changed to use "%u" rather
> than "%lu" to print the result of "pntohl()" - the "l" nonwithstanding,
> it returns a "guint32", which is an "unsigned int".

Excellent.

> I added to your patch to "packet-ipv6.c" a cast of the result of
> "ntohl()" to "unsigned long", so that it's type-correct even if
> "ntohl()" doesn't return a "long" (which it might not on at least some
> 64-bit platforms).

Okay, I was going to test this with -Wall on FreeBSD/alpha which normally
points out more errors then my workstation (FreeBSD/i386).

Keep up the good work.

-- 
- bill fumerola - billf@xxxxxxxxxxxxxx - BF1560 - computer horizons corp -
- ph:(800) 252-2421 - bfumerol@xxxxxxxxxxxxxxxxxxxx - billf@xxxxxxxxxxx  -