On Wed, 28 Jul 1999, Thierry Andry wrote:
>
> Hi, here it comes.
>
> The patch + a (little) capture.
>
> Sorry for the patch but as I told you, I just blindly add functions
> where capture_raw and dissect_raw were and some DLT_ ETT_
> It works for me.
I was working on something very similar to decode clip packets, but your
code is a lot nicer than my hack, Thierry. As soon as I get a chance,
i'll try out the patch.
This brings up a question that I've been meaning to ask for a while now.
Why are there two different calling types for the dissect-* functions? I
first ran into this when I wrote the pppoe decoder. I wanted to be able
to call dissect_ppp(pd,offset,cap_len,tree), but dissect_ppp was written
as a top-level three argument dissector without the offest argument. In my
clip hack, I wanted to call dissect_ip as a three argument dissector, but
it was only available in the four argument style. Thierry handles the
situation by wraping the dissect_ip(,,,) call in a dissect_clip(,,) call,
which is arguably the correct thing to do-- but I'd like to hear the
argument. ;')
-jsj
