Ethereal-dev: Re: [ethereal-dev] ethereal packet-ftp.c packet-pop.c packet-smb.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxx (Guy Harris)
Date: Wed, 12 May 1999 22:59:19 -0700 (PDT)
> Would like to remove it from packet-tftp.c as well to remove our 
> dependence on that file as well.

I just did; there may be a checkin announcement message mailed, but, if
not, I:

	put the #defines for packet types directly into "packet-tftp.c";

	made it grab the opcode directly from the first 2 bytes of the
	packet with "pntohs()", so the TFTP header structure isn't
	necessary.

The latter change also keeps Ethereal from crashing on processors
requiring strict alignment if the UDP payload isn't aligned on a 2-byte
boundary (as might be the case with, for example, an FDDI capture); I
also changed the code that grabs the block number to use "pntohs()" to
address the same problem.