Ethereal-dev: [ethereal-dev] GTK 1.2.1 bug/feature means "gtk_tree_set_view_mode()" has no eff

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxx (Guy Harris)
Date: Tue, 6 Apr 1999 01:38:50 -0700 (PDT)
When I build "ethereal" on a machine here with GTK 1.2.1 installed, it
drew lines in the tree view in the detail window; it appears that
there's a bug in GTK 1.2.1, wherein "gtk_tree_set_view_mode()" has no
effect on the way tree views are drawn, the GTK+ 1.2[.x] tutorial
nonwithstanding.  GTK 1.0.6, at least, doesn't have this problem.

I sent this patch - which appears to fix the problem - to
"gtk-devel-list@xxxxxxxxxx", asking if this really *is* a bug, or a
feature:

*** gtktreeitem.c.dist	Wed Feb 24 02:15:13 1999
--- gtktreeitem.c	Tue Apr  6 00:35:36 1999
***************
*** 586,591 ****
--- 586,593 ----
  
    item = GTK_TREE_ITEM(widget);
    tree = GTK_TREE(widget->parent);
+   if (!tree->view_line)
+     return;
  
    /* draw vertical line */
    lx1 = item->pixmaps_box->allocation.width;