Ethereal-cvs: [Ethereal-cvs] rev 18089: /trunk/epan/dissectors/: packet-ldap.c /trunk/asn1/lda

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: sahlberg@xxxxxxxxxxxx
Date: Thu, 04 May 2006 10:19:33 GMT
User: sahlberg
Date: 2006/05/04 05:19 AM

Log:
 force the AssertionValue type to be displayed as a STRING instead of as hex BYTES.
 
 
 Most of the time  AssertionValue will contain an ascii string   so make it always display as a string to make the display "correct" most of the time insterad of being "wrong" most of the time.
 
 There are situations when AssertionValue contains binary data though  and in those cases the display will be "wrong" (but not more wrong than the old dissector anyway)
 
 
 What someone really should do (someone interested in ldap that is) to make it more correct would be to implement a dissector for AssertionValue in the template file and having the dissector check if any of the bytes of the octet string has a value <32   and if so display it in hex as   0x.....
 It all bytes have values >=32   then it shoudlk display it as a string "...
 instead.
 
 Someone interested in ldap may spend time on this refinement.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +17 -17    packet-ldap.c    Modified

Directory: /trunk/asn1/ldap/
  Changes    Path          Action
  +1 -0      ldap.cnf      Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=18089&view=rev