Ethereal-cvs: [Ethereal-cvs] rev 13917: /trunk/epan/dissectors/: packet-fcp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx
Date: Sat, 26 Mar 2005 03:57:02 -0000
User: guy
Date: 2005/03/25 09:56 PM

Log:
 Get rid of boilerplate.
 
 Use "tvb_ensure_bytes_exist()" to check for some invalid lengths.
 
 Add some comments about possible problems in the code.
 
 Get rid of an unnecessary length check (the length is the sum of a small
 constant and a value extracted from a single byte, so the sum won't
 overflow).
 
 For a FCP_RSP, make the top-level protocol tree item run to the end of
 the tvbuff and then set its length when we finish dissecting it (if we
 throw an exception and don't get around to setting the length, that
 means that we hit the end of the tvbuff before we hit the end of the
 item).  Add some checks to catch too-large length fields.

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +35 -42    packet-fcp.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=13917&view=rev