Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal/gtk file_dlg.c find_dlg.c io_stat.c main.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx (Guy Harris)
Date: Tue, 10 Feb 2004 18:55:28 -0600 (CST)
guy         2004/02/10 18:55:28 CST

  Modified files:
    gtk                  file_dlg.c find_dlg.c io_stat.c main.c 
  Log:
  Add a routine to be used to put up alert boxes for invalid display
  filter expressions; use that in a number of places, so we use the same
  alert box.  (More work is needed to figure out the right way to handle
  some other "dfilter_compile()" failures.)
  
  Use the error message from the display filter as the primary error, as
  that's the message that tells you what the underlying problem is.  (The
  GNOME HIG says "In most situations the user should only need the primary
  text to make a quick decision", so the primary text should tell you
  what's wrong with the filter, not just that it's invalid.  If there are
  messages from the display filter code that don't give enough
  information, or are a bit cryptic, such as "Unexpected end of filter
  string," those should be fixed in the display filter code.)
  
  Improve the error used if an empty filter is used for "find frame".
  
  Revision  Changes    Path
  1.94      +3 -2      ethereal/gtk/file_dlg.c
  1.46      +4 -3      ethereal/gtk/find_dlg.c
  1.60      +3 -3      ethereal/gtk/io_stat.c
  1.392     +3 -2      ethereal/gtk/main.c