Ethereal-cvs: Re: [Ethereal-cvs] cvs commit: ethereal/gtk2 packet_list.c Makefile.am packet_wi
From: "Olivier Abad"
Sent: Saturday, September 21, 2002 9:36 PM
Subject: [Ethereal-cvs] cvs commit: ethereal/gtk2 packet_list.c Makefile.am
packet_win.h proto_draw.c proto_draw.h ui_util.c
> oabad 2002/09/21 06:36:31 CDT
>
> Modified files:
> gtk2 Makefile.am packet_win.h proto_draw.c
> proto_draw.h ui_util.c
> Added files:
> gtk2 packet_list.c
> Log:
> Removed all gtk calls in file.c :
> - created a few packet_list_xxx functions (ui_util.h gtk/packet_list.c
> gtk2/packet_list.c) ;
> - removed almost all "gtk/xxx" and "gtk2/xxx" includes in file.c
>
> The only remaining includes are related to color filters. We have to
> make color_filter_t GUI independent by replacing GdkColor with color_t.
> I'll work on this later.
I better tell you, and others...
With the new tap system it is perfectly possible to implement the color
filters
as simple tap extensions.
If the color filters are changed to use tapping instead of explicit code in
file.c
we could remove everything related to color-filters from file.c.
This would make file.c much simpler.
After that, we could possibly convert the displayfilters to use very simple
tapping as well which would remove that dependency on stuff down in gtk/gtk2
from file.c
as well.
With both the changes above, I think that we would rid file.c of all
dependensies to gtk/gtk2 thus making int much cleaner and much more to the
point (its name is file.c , not colorfilters.c or displayfilters.c)
I will look into the color filter conversion during the next few days.
