Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-cdp.c packet-dns.c packet-isup.c pack

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 28 Aug 2001 03:28:16 -0500 (CDT)
guy         2001/08/28 03:28:15 CDT

  Modified files:
    .                    packet-cdp.c packet-dns.c packet-isup.c 
                         packet-sctp.c packet-vtp.c 
  Log:
  Get rid of "proto_tree_add_notext()" - if you create a subtree using it,
  but, before you set the text, you throw an exception while putting stuff
  under the subtree, you end up with an absolutely blank protocol tree
  item, which is really gross.  Instead of calling
  "proto_tree_add_notext()", call "proto_tree_add_text()" with at least a
  minimal label - yes, it does mean you do some work that will probably be
  unnecessary, but, absent a scheme to arrange to do that work if it *is*
  necessary (e.g., catching exceptions), the alternative is an ugly
  protocol tree display.
  
  Revision  Changes    Path
  1.39      +5 -12     ethereal/packet-cdp.c
  1.71      +5 -3      ethereal/packet-dns.c
  1.5       +147 -43   ethereal/packet-isup.c
  1.20      +8 -5      ethereal/packet-sctp.c
  1.15      +6 -9      ethereal/packet-vtp.c