Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-nbipx.c packet-netbios.c packet-netbi

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 14 Jan 2001 22:39:29 -0600 (CST)
guy         2001/01/14 22:39:29 CST

  Modified files:
    .                    packet-nbipx.c packet-netbios.c 
                         packet-netbios.h 
  Log:
  "get_netbios_name()" can never return a negative number as the name
  type, so "netbios_add_name()" doesn't need to check for it doing so
  (yes, the tvbuff stuff *does* catch "get_netbios_name()" running past
  the end of the packet, and causes an exception to be thrown).  Get rid
  of the check, and get rid of "netbios_add_name()"s return value.
  
  In "dissect_nbipx_dg()", always call the SMB dissector if there's data
  left in the packet, regardless of whether the "tree" argument is null or
  not; subdissectors should always be called, so they can build any
  internal state on the first pass through the capture, and so that they
  can fill in the Protocol and Info columns.
  
  Revision  Changes    Path
  1.36      +29 -33    ethereal/packet-nbipx.c
  1.30      +11 -33    ethereal/packet-netbios.c
  1.9       +2 -2      ethereal/packet-netbios.h