Ethereal-cvs: [ethereal-cvs] cvs commit: ethereal packet-llc.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Gilbert Ramirez Jr." <gram@xxxxxxxxxxxx>
Date: Fri, 12 May 2000 00:06:30 -0500 (CDT)
gram        2000/05/12 00:06:28 CDT

  Modified files:
    .                    packet-llc.c 
  Log:
  In wiretap, set err to 0 before doing anything inside wtap_loop().
  Tethereal was dying on me because err was initialized to some random value.
  
  It was this section of code that would exit even if wtap_loop was successful
  (returned TRUE) because err was never initialized or set to anything.
  
  err = load_cap_file(&cf, out_file_type);
  if (err != 0) {
         dissect_cleanup();
         exit(2);
  }
  
  <BIGGER sheepish grin>
  Fixed even more errors in LLC dissector. I had inadvertantly used the
  wrong tvbuff_t* when calling dissect_data_tvb(). There is no way we are going
  to be successful in this tvbuff conversion w/o regression testing. I'm
  working on setting up a simple Makefile for regression testing tonight.
  That's why I'm finding so many bugs in my LLC conversion.
  </BIGGER sheepish grin>
  
  Revision  Changes    Path
  1.59      +7 -7      ethereal/packet-llc.c